<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p></p>
<div>
<p>Hi Steven,</p>
<p><br>
</p>
<p>I'm glad we're booking some progress.</p>
<p><br>
</p>
I have tried to reproduce the error messages that you report when adding "MeV" before the polynomial of the energy spread and running with Gate v8.2. When I run with the attached source file, it actually seems to run normally for me. The unit specification
(MeV or percent) should be given in the content line immediately before the order of the energy spread polynomial. Since you write that you tried to insert in many places, I assume that you actually already tried to add it in the correct place. But I could
reproduce your error message (complaining about line 16 in the source props file) if I misspell MeV, e.g. as MEV.</div>
<div><br>
</div>
<div>For percent, the code allows different spellings (PERCENT, percent or %) but for MeV it's very picky, it only recognizes "MeV", with exactly that capitalization. "MEV" is not accepted, nor is "mev". Could it be that you actually inserted one of those "wrong"
spellings? If you think you did already write it correctly, could you check with 'diff' or send me your source props file that includes the MeV line?</div>
<div><br>
</div>
<div>I guess we can improve the parsing code by:</div>
<div>
<ul style="margin-bottom:0px; margin-top:0px">
<li>ignoring upper/lower case completely</li><li>recognize when the user tries to specify the name of a unit (not a number) in that particular line, and throw an informative error with a list of which names would be recognized and accepted.<br>
</li></ul>
</div>
<p></p>
<p><br>
</p>
<p>Thanks for reporting!</p>
<p>/David</p>
<p><br>
</p>
<p>PS: BTW, if you use a Windows mail client (I do, unfortunately) then the attached text file will probably be saved with DOS style line endings. In Linux you can detect this with the "file" command, like "file sourceprops.txt" and if it says "<span>ASCII
text, with CRLF line terminators</span>" then you know that it was jinxed by Microsoft. It can be unjinxed with "dos2unix sourceprops.txt". I think every major Linux distribution has the "dos2unix" utility in their package repository.<br>
</p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> COURT, Steven (UNIVERSITY COLLEGE LONDON HOSPITALS NHS FOUNDATION TRUST) <steven.court@nhs.net><br>
<b>Gesendet:</b> Montag, 17. August 2020 16:53:57<br>
<b>An:</b> gate-users@lists.opengatecollaboration.org<br>
<b>Cc:</b> David Boersma<br>
<b>Betreff:</b> Re: Gate-users Digest, Vol 171, Issue 11</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">That's great, thank you David.<br>
<br>
It was indeed an issue with the "MeV" declaration in the source description file, which I had omitted. Adding it in my simulation now looks fine. I have attached the files you requested without the fix (though there is no error message raised, it just continues
parsing incorrectly).<br>
<br>
I then tried to use that corrected source description file in my v8.2 simulation, and no matter where I placed the "MeV" line I was getting an error stating that it was expecting an integer: "wrong number of values (0) on line 16 of data/SourceDescFile_Field1.txt,
expected 1 value(s) of type i". Looking at the source code for the 8.2 release I'm not sure why that is the case, I believe it should be fine. I can now run on both versions, so thanks again!<br>
<br>
Regards,<br>
Steve<br>
<br>
<br>
________________________________________<br>
From: Gate-users <gate-users-bounces@lists.opengatecollaboration.org> on behalf of gate-users-request@lists.opengatecollaboration.org <gate-users-request@lists.opengatecollaboration.org><br>
Sent: 17 August 2020 11:00<br>
To: gate-users@lists.opengatecollaboration.org<br>
Subject: Gate-users Digest, Vol 171, Issue 11<br>
<br>
Send Gate-users mailing list submissions to<br>
gate-users@lists.opengatecollaboration.org<br>
<br>
To subscribe or unsubscribe via the World Wide Web, visit<br>
<a href="http://lists.opengatecollaboration.org/mailman/listinfo/gate-users">
http://lists.opengatecollaboration.org/mailman/listinfo/gate-users</a><br>
or, via email, send a message with subject or body 'help' to<br>
gate-users-request@lists.opengatecollaboration.org<br>
<br>
You can reach the person managing the list at<br>
gate-users-owner@lists.opengatecollaboration.org<br>
<br>
When replying, please edit your Subject line so it is more specific<br>
than "Re: Contents of Gate-users digest..."<br>
<br>
<br>
Today's Topics:<br>
<br>
1. Re: Version 8.1 and 8.2 differences, PBT (David Boersma)<br>
<br>
<br>
----------------------------------------------------------------------<br>
<br>
Message: 1<br>
Date: Mon, 17 Aug 2020 09:44:45 +0000<br>
From: David Boersma <david.boersma@acmit.at><br>
To: "gate-users@lists.opengatecollaboration.org"<br>
<gate-users@lists.opengatecollaboration.org><br>
Subject: Re: [Gate-users] Version 8.1 and 8.2 differences, PBT<br>
Message-ID: <fe0592ae2bb04e2fbd32b10f05d35eb4@acmit.at><br>
Content-Type: text/plain; charset="iso-8859-1"<br>
<br>
Hi Steve,<br>
<br>
<br>
Sorry for the long wait. You can use "git" to check differences between different releases. On the command line, for instance, you could list all tags (releases):<br>
<br>
<br>
git tag -l<br>
<br>
<br>
And then you could run:<br>
<br>
<br>
git diff v8.1.p01 v8.2 -- ./source/physics/src/GateSourceTPSPencilBeam.cc<br>
<br>
<br>
(I hope that this command line does not get mangled in your email client...)<br>
<br>
<br>
This shows the differences in the GateSourceTPSPencilBeam.cc source file between the releases 8.1.p01 and 8.2. You can also look at the diffs in github, for instance:<br>
<br>
* go to <a href="https://github.com/OpenGATE/Gate">https://github.com/OpenGATE/Gate</a><br>
* click on "tags"<br>
* select the newest release tag for which you would like to do the comparison (8.2)<br>
* click "compare" and select the older release tag (8.1.p01)<br>
* you may have to wait a little bit while the server generates the diffs<br>
* select the "files changed" tab<br>
* find the file you're interested in and click "load diff"<br>
<br>
This should result in something like this:<br>
<br>
<a href="https://github.com/OpenGATE/Gate/compare/v8.1.p01...v8.2#diff-8f950e0d41b247abb5f0a77d4f0b2832L324">https://github.com/OpenGATE/Gate/compare/v8.1.p01...v8.2#diff-8f950e0d41b247abb5f0a77d4f0b2832L324</a><br>
<br>
<br>
<<a href="https://github.com/OpenGATE/Gate/compare/v8.1.p01...v8.2#diff-8f950e0d41b247abb5f0a77d4f0b2832L324">https://github.com/OpenGATE/Gate/compare/v8.1.p01...v8.2#diff-8f950e0d41b247abb5f0a77d4f0b2832L324</a>>As you can see in the diff, nothing changed
in the parsing of the optical part of the source properties file, but there were changes in the parsing of the energy spread (MEV versus PCT). The 8.1 code has the number of lines to skip hardcoded, while in later releases it just skips whatever number of
non-content lines (empty or comments) you have inserted. If some of the previously skipped lines could be construed as a "content line" (not empty, no comment) then it's possible that all lines after that will be misinterpreted, including the divergence polynomials.
Maybe that's what happened with your source properties file.<br>
<br>
<br>
We have made an effort to detect such mishaps in the parsing so that you'll get a crash with an informative error message in such cases. But I've noticed that this error detection is not yet fool proof: it is still possible to give it incorrect source properties
input which is then read silently, with bogus results.<br>
<br>
<br>
In short: could you please send us your source properties file (and maybe also the main macro and the plan file) so that we can see where the parsing goes wrong?<br>
<br>
<br>
HTH,<br>
<br>
David Boersma<br>
<br>
________________________________<br>
Von: Gate-users <gate-users-bounces@lists.opengatecollaboration.org> im Auftrag von COURT, Steven (UNIVERSITY COLLEGE LONDON HOSPITALS NHS FOUNDATION TRUST) <steven.court@nhs.net><br>
Gesendet: Donnerstag, 6. August 2020 16:25:39<br>
An: gate-users@lists.opengatecollaboration.org<br>
Betreff: [Gate-users] Version 8.1 and 8.2 differences, PBT<br>
<br>
<br>
Hi all,<br>
<br>
<br>
I've been simulating some proton treatments in virtual Gate 8.2 and all looks good, but when I run the same simulation in 8.1 (to be in line with Gate-RTIon) the beam has a ridiculous divergence. I suspect some change to the source description file, perhaps
between rads / mrads, or in the ordering of the polynomials, I'm not sure yet.<br>
<br>
<br>
Can anyone tell me what's up, or point me to a document where I can see all changes made between versions 8.1 and 8.2?<br>
<br>
<br>
Thanks a lot,<br>
<br>
Steve<br>
<br>
<br>
********************************************************************************************************************<br>
<br>
This message may contain confidential information. If you are not the intended recipient please inform the<br>
sender that you have received the message in error before deleting it.<br>
Please do not disclose, copy or distribute information in this e-mail or take any action in relation to its contents. To do so is strictly prohibited and may be unlawful. Thank you for your co-operation.<br>
<br>
NHSmail is the secure email and directory service available for all NHS staff in England and Scotland. NHSmail is approved for exchanging patient data and other sensitive information with NHSmail and other accredited email services.<br>
<br>
For more information and to find out how you can switch, <a href="https://portal.nhs.net/help/joiningnhsmail">
https://portal.nhs.net/help/joiningnhsmail</a><br>
<br>
-------------- next part --------------<br>
An HTML attachment was scrubbed...<br>
URL: <<a href="http://lists.opengatecollaboration.org/pipermail/gate-users/attachments/20200817/d74033d3/attachment-0001.html">http://lists.opengatecollaboration.org/pipermail/gate-users/attachments/20200817/d74033d3/attachment-0001.html</a>><br>
<br>
------------------------------<br>
<br>
Subject: Digest Footer<br>
<br>
_______________________________________________<br>
Gate-users mailing list<br>
Gate-users@lists.opengatecollaboration.org<br>
<a href="http://lists.opengatecollaboration.org/mailman/listinfo/gate-users">http://lists.opengatecollaboration.org/mailman/listinfo/gate-users</a><br>
<br>
------------------------------<br>
<br>
End of Gate-users Digest, Vol 171, Issue 11<br>
*******************************************<br>
<br>
<br>
********************************************************************************************************************<br>
<br>
This message may contain confidential information. If you are not the intended recipient please inform the<br>
sender that you have received the message in error before deleting it.<br>
Please do not disclose, copy or distribute information in this e-mail or take any action in relation to its contents. To do so is strictly prohibited and may be unlawful. Thank you for your co-operation.<br>
<br>
NHSmail is the secure email and directory service available for all NHS staff in England and Scotland. NHSmail is approved for exchanging patient data and other sensitive information with NHSmail and other accredited email services.<br>
<br>
For more information and to find out how you can switch, <a href="https://portal.nhs.net/help/joiningnhsmail">
https://portal.nhs.net/help/joiningnhsmail</a><br>
<br>
</div>
</span></font>
</body>
</html>