<div dir="ltr"><div>Dear <span style="font-family:arial,sans-serif;font-size:13px">Gergely</span>,</div><div><br></div><div>I integrated the patches in the "develop" branch. You should be able to look at the branch in the git source code (or in <a href="https://github.com/OpenGATE/Gate">github here</a>, thanks to Mojca). I quickly look and compile everything without problem. I only perform one quick simulation test. Could you (Gergely, Seb, Albertine ... others) please try to run some simulations benchmarks to test ? In particular, as I do not use interfile, please check this file format. Moreover, Gergely, could I ask you to add a (short) description of the new shapes you provide in the documentation ? Please, ask for a login in the <a href="http://wiki.opengatecollaboration.org/index.php/Users_Guide_V7.0:Defining_a_geometry#Creating_a_volume" target="_blank">wiki documentation</a> and directly modify the text.</div>
<div><br></div><div>Thanks again for this important and really appreciated contributions !<br></div><div><br></div><div>Sincerely,</div><div>David</div><div><br></div><div>For those who are interested, here are the commands to apply patches: </div>
<div><div>patch -p1 < cppfix_dvolgyes.patch<br></div><div>(git commit etc ...)</div><div>git commit --amend --author="David Volgyes <<a href="mailto:david.volgyes@gmail.com" target="_blank">david.volgyes@gmail.com</a>>"</div>
<div><br></div><div>patch -p1 < geant4-geometry.patch</div><div>(git commit and add etc ...)</div><div>git commit --amend --author="Patay Gergely <<a href="mailto:patay.gergely@mediso.hu" target="_blank">patay.gergely@mediso.hu</a>>"</div>
<div><br></div><div>patch -p1 < interfile.patch</div></div><div><div>(git commit and add etc ...)</div></div><div><div>git commit --amend --author="Patay Gergely <<a href="mailto:patay.gergely@mediso.hu" target="_blank">patay.gergely@mediso.hu</a>>"</div>
</div><div><br>
</div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jun 18, 2014 at 10:54 AM, Patay Gergely <span dir="ltr"><<a href="mailto:patay.gergely@mediso.hu" target="_blank">patay.gergely@mediso.hu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Dear Gaters,<br>
<br>
here are a few patches against the upstream (ie. master branch) Gate source code. Since I am not a member of the collaboration, I cannot directly commit them into the git repository.<br>
<br>
The first patch was written by Dávid Völgyes (formerly at Mediso and at COMPET). These are C++ bugfixes (unchecked ranges, memory corruptions).<br>
[1] <a href="https://dl.dropboxusercontent.com/u/43097994/gate7/cppfix_dvolgyes.patch.gz" target="_blank">https://dl.dropboxusercontent.<u></u>com/u/43097994/gate7/cppfix_<u></u>dvolgyes.patch.gz</a><br>
<br>
The second patch contains Gate wrappers to all the missing Geant4 solid objects from <a href="http://geant4.web.cern.ch/geant4/UserDocumentation/UsersGuides/ForApplicationDeveloper/html/ch04.html" target="_blank">http://geant4.web.cern.ch/<u></u>geant4/UserDocumentation/<u></u>UsersGuides/<u></u>ForApplicationDeveloper/html/<u></u>ch04.html</a> .<br>
With this patch the following extra shapes will be available: cut tube, elliptical cone, generic trapezoid, hyperbolic tube, parallelepiped, paraboloid tube, tetrahedron, torus, twisted box, twisted trapezoid, generic twisted trapezoid and twisted tube segment.<br>
[2] <a href="https://dl.dropboxusercontent.com/u/43097994/gate7/geant4-geometry.patch.gz" target="_blank">https://dl.dropboxusercontent.<u></u>com/u/43097994/gate7/geant4-<u></u>geometry.patch.gz</a><br>
<br>
The third patch is a heavy modification of the Interfile reader. Besides some code cleaning and refactoring, it solves the following issues:<br>
- if the key 'name of data file' is present in the header file then it won't guess the name<br>
- the 'number of bytes per pixel' key (1,2,4,8...) is implemented<br>
- the 'data offset in bytes' key is implemented<br>
- the 'number format' key now accepts 'signed integer', 'unsigned integer', 'short float', 'long float' and (for convenience) 'float', as seen in the Interfile 3.3 standard.<br>
The interfile reader thus accepts signed or unsigned 8, 16, 32 or 64 bit integer as well as 32 (float) or 64 bit (double) floating point data from little or big endian binary file.<br>
[3] <a href="https://dl.dropboxusercontent.com/u/43097994/gate7/interfile.patch.gz" target="_blank">https://dl.dropboxusercontent.<u></u>com/u/43097994/gate7/<u></u>interfile.patch.gz</a><br>
<br>
cheers,<br>
Gergely<br>
<br>
---<br>
Gergely Patay<br>
physicist<br>
Mediso Medical Imaging Systems Ltd.<br>
Hungary<br>
______________________________<u></u>_________________<br>
Gate-users mailing list<br>
<a href="mailto:Gate-users@lists.opengatecollaboration.org" target="_blank">Gate-users@lists.<u></u>opengatecollaboration.org</a><br>
<a href="http://lists.opengatecollaboration.org/mailman/listinfo/gate-users" target="_blank">http://lists.<u></u>opengatecollaboration.org/<u></u>mailman/listinfo/gate-users</a></blockquote></div><br><br clear="all"><div>
<br></div>-- <br><div dir="ltr">David Sarrut, Phd<br>Directeur de recherche CNRS<br>CREATIS, UMR CNRS 5220, Inserm U 1044<div>Centre de lutte contre le cancer Léon Bérard<br>28 rue Laënnec, 69373 Lyon cedex 08<br>Tel : 04 78 78 51 51 / 06 74 72 05 42<br>
<a href="http://www.creatis.insa-lyon.fr/~dsarrut" target="_blank">http://www.creatis.insa-lyon.fr/~dsarrut</a><br>_________________________________</div><div> "2 + 2 = 5, for extremely large values of 2"<br>_________________________________</div>
</div>
</div>